Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: dual state menu demo #33999

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

chore: dual state menu demo #33999

wants to merge 3 commits into from
+137 −90

Conversation

jurokapsiar
Copy link
Contributor

Demo of dual state menu

@github-actions github-actions bot added this to the March Project Cycle Q1 2025 milestone Mar 16, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 16, 2025 •
edited
Loading

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 225.885 kB
65.402 kB		 225.696 kB
65.365 kB		 -189 B
-37 B
react-components
react-components: entire library		 1.225 MB
308.799 kB		 1.225 MB
308.752 kB		 -190 B
-47 B
react-menu
Menu (including children components)		 155.638 kB
46.887 kB		 155.448 kB
46.843 kB		 -190 B
-44 B
react-menu
Menu (including selectable components)		 158.62 kB
47.484 kB		 158.43 kB
47.444 kB		 -190 B
-40 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-avatar
Avatar		 49.329 kB
15.824 kB
react-avatar
AvatarGroup		 20.132 kB
7.976 kB
react-avatar
AvatarGroupItem		 63.473 kB
20.043 kB
react-breadcrumb
@fluentui/react-breadcrumb - package		 114.719 kB
31.752 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 69.638 kB
20.24 kB
react-components
react-components: FluentProvider & webLightTheme		 44.473 kB
14.597 kB
react-datepicker-compat
DatePicker Compat		 225.993 kB
64.072 kB
react-dialog
Dialog (including children components)		 101.691 kB
30.584 kB
react-overflow
hooks only		 12.832 kB
4.828 kB
react-persona
Persona		 56.22 kB
17.704 kB
react-popover
Popover		 131.072 kB
41.023 kB
react-portal-compat
PortalCompatProvider		 8.39 kB
2.64 kB
react-table
DataGrid		 160.994 kB
45.684 kB
react-table
Table (Primitives only)		 42.692 kB
13.862 kB
react-table
Table as DataGrid		 131.895 kB
36.579 kB
react-table
Table (Selection only)		 70.562 kB
20.007 kB
react-table
Table (Sort only)		 69.205 kB
19.618 kB
react-tag-picker
@fluentui/react-tag-picker - package		 186.441 kB
56.041 kB
react-tags
InteractionTag		 15.461 kB
6.224 kB
react-tags
Tag		 29.849 kB
9.732 kB
react-tags
TagGroup		 83.532 kB
24.803 kB
react-teaching-popover
TeachingPopover		 101.379 kB
30.47 kB
react-timepicker-compat
TimePicker		 109.01 kB
36.221 kB
react-tree
FlatTree		 148.348 kB
42.568 kB
react-tree
PersonaFlatTree		 149.093 kB
42.712 kB
react-tree
PersonaTree		 145.299 kB
41.568 kB
react-tree
Tree		 144.56 kB
41.443 kB
🤖 This report was generated against a296894de6f9acaaa562344ae4c09ba278fcc745

@github-actions GitHub Actions
Copy link

Pull request demo site: URL

fabricteam
fabricteam reviewed Mar 16, 2025
View reviewed changes
apps/public-docsite-v9/src/AccessibilityScenarios/Menu.stories.tsx
@@ -71,7 +71,7 @@ export const ProfileMenu: React.FunctionComponent = () => {
<Scenario pageTitle="Profile menu">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv9 Visual Regression Report

Avatar Converged 1 screenshots
Image Name Diff(in Pixels) Image Type
Avatar Converged.badgeMask.normal.chromium.png 1 Changed
Drawer 1 screenshots
Image Name Diff(in Pixels) Image Type
Drawer.overlay drawer full - RTL.chromium.png 1172 Changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
March Project Cycle Q1 2025
Development

Successfully merging this pull request may close these issues.
2 participants
@jurokapsiar @fabricteam